fix: ensure StakingBalance is shown or hidden appropriately per asset… #12987
+129
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
nickewansmith
added
needs-assets-ux-review
|
nickewansmith
force-pushed
the
STAKE-921-mobile-asset-detail-staking-balance-shows-for-eth-assets-on-unsupported-chains-with-popular-networks-filter
branch
from
a551ef7 to
f3e049d
Compare
nickewansmith
added
Run Smoke E2E
|
|
Matt561
approved these changes
Jan 15, 2025
Prithpal-Sooriya
approved these changes
Jan 15, 2025
nickewansmith
deleted the
STAKE-921-mobile-asset-detail-staking-balance-shows-for-eth-assets-on-unsupported-chains-with-popular-networks-filter
branch
metamaskbot
added
the
release-7.39.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are 2 separate issues that are both related to the StakedBalance component. One is Asset Detail StakingBalance shows for ETH assets on unsupported chains with popular networks filter. The other is Asset Detail StakingBalance does not show for mainnet ETH asset when on unsupported chain with popular networks filter.
The user will not see staked ethereum info for assets that are not mainnet Ethereum asset when on mainnet
The user will see staked ethereum info when on unsupported chain with popular networks filter and viewing the mainnet Ethereum asset detail. We show the details but hide any staking actions for the time being while we re-evaluate how to keep the actions and switch the network on the fly.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/STAKE-921
Manual testing steps
Asset Detail StakingBalance shows for ETH assets on unsupported chains with popular networks filter
Switch to mainnet network
Switch to popular networks filter
Select the native asset of a popular network that is not mainnet, such as Base or Optimism
In the asset detail page you should not see staked ethereum info
Asset Detail StakingBalance does not show for mainnet ETH asset when on unsupported chain with popular networks filter
Switch to Base network
Switch to popular networks filter
Select the mainnet Ethereum asset
In the asset detail page you should see staked ethereum info and earnings info but no action buttons or claim link banners
Screenshots/Recordings
Before
Screen.Recording.2025-01-15.at.8.19.49.AM.mov
After
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-15.at.08.18.44.mp4
Pre-merge author checklist
Pre-merge reviewer checklist